fullcalendar / fullcalendar-vue

The official Vue 3 component for FullCalendar
https://fullcalendar.io/docs/vue
MIT License
1.41k stars 88 forks source link

vue 2.x to vue 3.x #148

Closed marvelbark2 closed 3 years ago

marvelbark2 commented 3 years ago

Updating vue APi with the new APIs

acerix commented 3 years ago

Thanks, this fixes https://github.com/fullcalendar/fullcalendar-vue/issues/131 ?

jippeholwerda commented 3 years ago

I would expect the version of Vue to be updated in package.json as well?

marvelbark2 commented 3 years ago

You will use a vue 3 so that mean you should update your fullcalendar vue sdk

aliasaria commented 3 years ago

This doesn't build for me: npm run build

results in:

> tsc -p tsconfig.json && rollup -c && npm run minify

src/FullCalendar.ts:15:32 - error TS1005: ',' expected.

15 const FullCalendar = Vue.extend{
                                  ~

src/FullCalendar.ts:18:21 - error TS1005: ',' expected.

18     options: Object as PropType<CalendarOptions>
                       ~~

src/FullCalendar.ts:18:24 - error TS1005: ',' expected.
...
marvelbark2 commented 3 years ago
Vue.extend

Hey , You should delete Vue.extend on const FullCalendar = ...

aliasaria commented 3 years ago

@marvelbark2 do you mean you can get npm run build to build this project? Removing this doesn't fix the build. I am just building a plain copy of your code:

https://github.com/marvelbark2/fullcalendar-vue/blob/patch-2/src/FullCalendar.ts

marvelbark2 commented 3 years ago

@aliasaria I fixed the issue !

arshaw commented 3 years ago

note to self: releasing this will break compatibility with Vue 2. release this as a version like 5.1.2-vue3, then have a dist-tag called vue3 that makes npm-installing more convenient.

any input on a better release strategy is welcome

potraike commented 3 years ago

Hi, do you have any plans when this release will be available?

guifischer commented 3 years ago

Any chance to get a vue 3 "beta" branch with this changes?

arshaw commented 3 years ago

I've merged this into the vue3 branch and released it as the @fullcalendar/vue3 package!

arshaw commented 3 years ago

(it required quite a bit more work), but thanks so much for helping me get started!