Closed marvelbark2 closed 3 years ago
Thanks, this fixes https://github.com/fullcalendar/fullcalendar-vue/issues/131 ?
I would expect the version of Vue to be updated in package.json
as well?
You will use a vue 3 so that mean you should update your fullcalendar vue sdk
This doesn't build for me:
npm run build
results in:
> tsc -p tsconfig.json && rollup -c && npm run minify
src/FullCalendar.ts:15:32 - error TS1005: ',' expected.
15 const FullCalendar = Vue.extend{
~
src/FullCalendar.ts:18:21 - error TS1005: ',' expected.
18 options: Object as PropType<CalendarOptions>
~~
src/FullCalendar.ts:18:24 - error TS1005: ',' expected.
...
Vue.extend
Hey , You should delete
Vue.extend
on const FullCalendar = ...
@marvelbark2 do you mean you can get npm run build
to build this project? Removing this doesn't fix the build. I am just building a plain copy of your code:
https://github.com/marvelbark2/fullcalendar-vue/blob/patch-2/src/FullCalendar.ts
@aliasaria I fixed the issue !
note to self: releasing this will break compatibility with Vue 2. release this as a version like 5.1.2-vue3
, then have a dist-tag called vue3
that makes npm-installing more convenient.
any input on a better release strategy is welcome
Hi, do you have any plans when this release will be available?
Any chance to get a vue 3 "beta" branch with this changes?
I've merged this into the vue3
branch and released it as the @fullcalendar/vue3
package!
(it required quite a bit more work), but thanks so much for helping me get started!
Updating vue APi with the new APIs