fullcalendar / fullcalendar

Full-sized drag & drop event calendar in JavaScript
https://fullcalendar.io
MIT License
18.48k stars 3.6k forks source link

TimeLineView visibleRange issue #5584

Open abdulwahab247 opened 4 years ago

abdulwahab247 commented 4 years ago

Hello Guys, In TimeLineView, calendar is crashing when I try to set visibleRange between {start: "2017-08-03", end: "2019-01-25"} and I have lot of events so I need them to be visible in given range of date.

Here is the code in codepen: https://codepen.io/abdulwahab4acetech/pen/GRoyBgR

Issue in screen shot: image

Appreciate any help or fix, Thanks

iiibbbmmm commented 4 years ago

Confirmed. More then 539 days can always reproduce the problem. Tracing differences between 539 and 540 with browser debugging, found following: In main.js line 57, Column 4170

  function A(l, u, i, t, r, o, f, e, c) {
    ...
  }

If 539 days, array f is filled with 2135 items. But in 540 days case, f is only filled with 51 items, causing only 18 fc-timeline-slot tags with 1st of each month generated. I can't find it in source code, so it might be a lib issue.

acerix commented 4 years ago

I believe the main issue is with slotLabelFormat; since you probably don't want a label for every day, you could remove the second line to only label the months. Also, setting slotMinWidth to 20px is not wide enough to show the month name.

https://codepen.io/acerix/pen/dyGmXwB?editable=true&editors=001%3Dhttps%3A%2F%2Ffullcalendar.io%2Freduced-test-cases

abdulwahab247 commented 4 years ago

Thanks for the response, I definitely do need a label for every day, and I set slotMinWidth to 20px to make the slot smaller to get the maximum view.

Here is the working screenshot without crash to get the idea: image

abdulwahab247 commented 4 years ago

I am using Fullcalendar v4, will this be fixed for v4 too?

arshaw commented 4 years ago

It seems this all works in v5: https://codepen.io/arshaw/pen/WNrPMOV?editable=true&editors=001 Here is the same example working in v4: https://codepen.io/arshaw/pen/wvMNyqZ?editable=true&editors=001

@abdulwahab247, is a bug still present? You say things are "crashing" under certain circumstances. Can you past a link to a codepen, based off on of the links above, that demonstrates the problem?

abdulwahab247 commented 4 years ago

It seems the bug is gone if we define the value of slotDuration property in calendar. But if we don't give the value for slotDuration the bug is still there. See this codepen example without slotDuration: https://codepen.io/abdulwahab4acetech/pen/GRoyBgR?editors=0110