fullcontact / full.http

Async HTTP client and server on top of http-kit and clojure.core.async
Eclipse Public License 1.0
2 stars 6 forks source link

Upgrade http-kit for JDK 9 #4

Open tirkarthi opened 6 years ago

tirkarthi commented 6 years ago

It seems that the project uses a version of http-kit that is incompatible with JDK 9 and above. It is fixed upstream and upgrading it will help in JDK 9 compatibility.

Relevant http-kit upstream issue : https://github.com/http-kit/http-kit/issues/356 Relevant release : https://github.com/http-kit/http-kit/releases/tag/2.3.0-beta2 Latest RC release : https://github.com/http-kit/http-kit/releases/tag/v2.3.0-RC1

This was reported using Clojars metadata and GitHub search. Feel free to close this if it's irrelevant.

➜  foo lein repl
nREPL server started on port 33226 on host 127.0.0.1 - nrepl://127.0.0.1:33226
REPL-y 0.3.7, nREPL 0.2.12
Clojure 1.9.0
Java HotSpot(TM) 64-Bit Server VM 9.0.4+11
    Docs: (doc function-name-here)
          (find-doc "part-of-name-here")
  Source: (source function-name-here)
 Javadoc: (javadoc java-object-or-class-here)
    Exit: Control+D or (exit) or (quit)
 Results: Stored in vars *1, *2, *3, an exception in *e

user=> (require '[full.http.client :as c])
WARNING: boolean? already refers to: #'clojure.core/boolean? in namespace: clojure.tools.analyzer.utils, being replaced by: #'clojure.tools.analyzer.utils/boolean?
WARNING: boolean? already refers to: #'clojure.core/boolean? in namespace: clojure.tools.analyzer, being replaced by: #'clojure.tools.analyzer.utils/boolean?
WARNING: bounded-count already refers to: #'clojure.core/bounded-count in namespace: clojure.core.async, being replaced by: #'clojure.core.async/bounded-count

ClassNotFoundException javax.xml.bind.DatatypeConverter  jdk.internal.loader.BuiltinClassLoader.loadClass (BuiltinClassLoader.java:582)

project.clj

(defproject foo "0.1.0-SNAPSHOT"
  :description "FIXME: write description"
  :url "http://example.com/FIXME"
  :license {:name "Eclipse Public License"
            :url "http://www.eclipse.org/legal/epl-v10.html"}
  :dependencies [[org.clojure/clojure "1.9.0"]
                 [fullcontact/full.http "1.0.1"]])
tirkarthi commented 6 years ago

I could see fullcontact/http-kit a fork of http-kit being used a dependency. I don't know if it's intentional and the fix would be to apply the patch at https://github.com/http-kit/http-kit/issues/356 to the fork.

Feel free to close this if it's intentional.