search

fullctl / ixctl

Apache License 2.0
2 stars 4 forks source link

Add Github Actions and swap Poetry for Pipenv #38

Closed egfrank closed 3 years ago

egfrank commented 3 years ago

Addresses https://github.com/fullctl/ixctl/issues/36 and https://github.com/fullctl/ixctl/issues/37

@vegu I left some comments for you in #36 so let's discuss what exceptions to Flake we can include.

@grizz can you take a look at the Dockerfile to see if you like how I implemented Poetry installing the dependencies into the Venv

And @grizz also make sure you approve of the github actions

vegu commented 3 years ago

Some tests are failing, but i think that's unrelated to this the scope of this branch, since all the changes requested in the review were made i am going to merge this to master now and we will fix the failing tests later