search

fullctl / ixctl

Apache License 2.0
2 stars 4 forks source link

Fix failing tests #39

Closed vegu closed 3 years ago

vegu commented 3 years ago

Look into tests that currently fail and figure if that's just cruft at this point to be removed, or fix them if not

egfrank commented 3 years ago

There are two PRs connected to this issue, one for ixctl to remove several tests and one for fullctl to add those tests back in.

@vegu It should be noted that the tests for fullctl are currently failing only on Python3.6 with the message ERROR: Package 'fullctl' requires a different Python: 3.6.12 not in '<4.0,>=3.7'. I'm not entirely sure if that's coming from the Poetry requirement or somewhere else. But in general tests were passing for Python3.7 3.8 3.9 so I wanted to make the PR https://github.com/fullctl/ixctl/pull/40 https://github.com/fullctl/fullctl/pull/6

vegu commented 3 years ago

Issues was this

 [tool.poetry.dependencies]
-python = "^3.7"
+python = "^3.6"

fixed and merged in fullctl/fullctl