fulldecent / FDTake

Easily take a photo or video or choose from library
MIT License
319 stars 121 forks source link

Adopt layout from https://github.com/fulldecent/swift5-module-template #117

Closed fulldecent closed 4 years ago

fulldecent commented 5 years ago

A modern project layout for Swift modules is defined at https://github.com/fulldecent/swift5-module-template

Work plan

For an example of a project that successfully adopted the modern project layout, see https://github.com/fulldecent/FDChessboardView and FDBarGauge

Follow-on work

yaroslav-zhurakovskiy commented 4 years ago

According to this https://bugs.swift.org/browse/SR-2866 SPM does currently support resources. We can't include "Localizable.strings" and any other assets into a swift package.

See also https://stackoverflow.com/questions/39815054/how-to-include-assets-resources-in-a-swift-package-manager-library

fulldecent commented 4 years ago

Good point.

Let's do this:

End result is that it works with Swift Package Manager and localization works but requires a couple of steps.

fulldecent commented 4 years ago

Fixed in c3450d12a3aaa2325465935c2efad156d76672de