search

fulldecent / aion-aip040

Reference implementation for Aion non-fungible tokens
MIT License
3 stars 3 forks source link

Review approach to fully qualified function names #13

Closed fulldecent closed 5 years ago

fulldecent commented 5 years ago

This project introduces a convention that function names and events will be fully qualified. E.g. AIP010Transferred, aip010TokenURI.

The intent is to encourage composability and prevent naming conflicts. Also this obviates the supportsInterface technique from ERC-165 and relies on Aion's superior function calling ability (i.e. function names are not hashing, resulting in collisions).

Seeking input from other AIP authors if this should be best practice.

fulldecent commented 5 years ago

Reviewed with Aion team. Decision is to proceed with prefixed function and events names for AIP standards.

Reference: phone meeting 2019-08-02 with @Jeff-aion and @jennjiuju.

fulldecent commented 5 years ago

Mentioning interested party: @satran004 from https://github.com/aionnetwork/AIP/issues/40#issuecomment-516428698