Closed fulldecent closed 7 years ago
Other low priority items:
Uncompressed images
great stuff -- will definitely be watching this project.
Couldn't find the --timeframe
flag in the htmlproofer docs and your usage helped fix my failing builds in travis CLI
Cheers
Thank you! FYI, here is more discussion about --timeframe
and making it work with continuous integration. (Still an unsolved topic.)
@VirenMohindra Thanks again, FYI, we are now 1.0.0
Broke this issue into individual items, closing.
.travis.yml
to callbundler exec rake test
Then add these things below into our
lightning_sites.rb
. Prefer to use thesh html-proofer ...
approach rather than native ruby implementation, if it will save time!htmlproofer --check-external-hash --check-favicon --check-html --check-img-http --check-opengraph --enforce-https --timeframe 30d
<link>
or<script>
go to https websites (done, use--enforce-https
above)<link>
and<script>
tags to external resources should use subresource integrity and CORS, see https://github.com/gjtorikian/html-proofer/issues/382)mailto:
links are awesome (include a subject or body)Separate
test_extensive
taskTests that work on a served version of the site (i.e.
php -S localhost:8000
)Currently we use this for travis: