fulldecent / github-pages-template

An opinionated starting point and build system for awesome, collaboratively-edited HTML websites
https://fulldecent.github.io/github-pages-template/
34 stars 50 forks source link

Add amazing travis file that checks for all kinds of stuff #2

Closed fulldecent closed 7 years ago

fulldecent commented 7 years ago

Then add these things below into our lightning_sites.rb. Prefer to use the sh html-proofer ... approach rather than native ruby implementation, if it will save time!

Separate test_extensive task

Tests that work on a served version of the site (i.e. php -S localhost:8000)

Currently we use this for travis:

language: ruby
rvm:
- 2.2.5

script:
 - bundle exec jekyll build
 - bundle exec htmlproofer ./_site

env:
  global:
  - NOKOGIRI_USE_SYSTEM_LIBRARIES=true # speeds up installation of html-proofer

sudo: false # route your build to the container-based infrastructure for a faster build
fulldecent commented 7 years ago

Other low priority items:

  1. Do not duplicate META descriptions across pages
  2. Do not duplicate TITLE tags across pages
  3. Validate HTML source code is valid

Uncompressed images

  1. https://developers.google.com/speed/docs/insights/OptimizeImages As a result, optimizing images can often yield some of the largest byte savings and performance improvements: the fewer bytes the browser has to download, the less competition there is for the client's bandwidth and the faster the browser can download and render content on the screen.
VirenMohindra commented 7 years ago

great stuff -- will definitely be watching this project.

Couldn't find the --timeframe flag in the htmlproofer docs and your usage helped fix my failing builds in travis CLI

Cheers

fulldecent commented 7 years ago

Thank you! FYI, here is more discussion about --timeframe and making it work with continuous integration. (Still an unsolved topic.)

https://github.com/gjtorikian/html-proofer/issues/381

fulldecent commented 7 years ago

@VirenMohindra Thanks again, FYI, we are now 1.0.0

fulldecent commented 7 years ago

Broke this issue into individual items, closing.

15, #16, #17, #18, #19, #20