search

fulldecent / swift5-module-template

An opinionated starting point for awesome, reusable Swift 5 modules
MIT License
450 stars 56 forks source link

.travis.yml file has some issues. Also an issue with the location of info.plist for the test target. #19

Closed lanza closed 7 years ago

lanza commented 7 years ago

  1. The WORKSPACE variable currently is set to WORKSPACE="__PROJECT_NAME__.xcworkspace"

  2. Similarly, IOS_FRAMEWORK_SCHEME="__PROJECT_NAME__"

  3. I had to set my DESTINATION="platform=iOS Simulator,OS=10.2,id=E40727B3-41FB-4D6E-B4CB-BFA87109EB12" for the destination to not be invalid and cause failure.

  4. The last line being CheckCocoaPodsQualityIndexes.rb ProjectName fails to find the file. I currently am trying ruby Tests/CheckCocoaPodsQualityIndexes.rb. But travis is running slow for some reason at the moment.

  5. The test target is looking for the info.plist file at ProjectNameTests/info.plist while it's actually at Tests/info.plist. This has to be changed in the test target's build settings.

lanza commented 7 years ago

I don't know ruby, but just from playing with the code

Dir.glob("**/*") do |file_name|

doesn't hit the .travis.yml file. I'd fix it, but it would be ugly hacky ruby code!

lanza commented 7 years ago

Fixed in #21