search

fulldecent / swift5-module-template

An opinionated starting point for awesome, reusable Swift 5 modules
MIT License
450 stars 56 forks source link

Fix main storyboard #29

Closed claui closed 7 years ago

claui commented 7 years ago

Fix recipe step

In step 3.7.1 of the recipe, the command to install the example Main.storyboard file uses shell escaping:

3. Create a project for your iOS Example project     7. Add source code with some functionality to the example         1. Use Terminal.app to insert some files into the project

    `cd ~/Desktop/__PROJECT_NAME__/iOS\ Example/`
    `curl 'https://`…**`iOS\ Example`**`/Source/Base.lproj/Main.storyboard' -o `…

which results in a 404 error.

The PR at hand replaces the shell encoding by URL encoding so the command works:

    `curl 'https://`…**`iOS%20Example`**`/Source/Base.lproj/Main.storyboard' -o `…

Fix storyboard reference

The PR also fixes a broken reference related to Main.storyboard in one of the project.pbxproj files, which resulted in a compile error for the iOS example project. That reference now correctly points to Base.proj/Main.storyboard.

fulldecent commented 7 years ago

Awesome, yes thanks again!