fulldecent / swift5-module-template

An opinionated starting point for awesome, reusable Swift 5 modules
MIT License
450 stars 56 forks source link

Remove development team ID #30

Closed claui closed 7 years ago

claui commented 7 years ago

This PR removes all occurrences of the development team ID from project.pbxproj files, which would lead to unsightly warnings if Xcode does not know that particular team ID.

The PR also updates the recipe to reflect this change. Since the recipe already assumes we’re on macOS, we can use (the macOS flavors of) find and sed to find and replace such IDs via Terminal.app. I feel this is more convenient than manual search-and-replace; besides, no text editor is needed while executing that step.

fulldecent commented 7 years ago

Thank you, looks great, merging.

fulldecent commented 7 years ago

Also, you have identified an undeclared input: Xcode. I have declared this in https://github.com/fulldecent/swift3-module-template/commit/b99187b62e9305e129ca8f73462647ac2c45e9df