fulldecent / system-bus-radio

Transmits AM radio on computers without radio transmitting hardware.
https://fulldecent.github.io/system-bus-radio/
MIT License
6.19k stars 386 forks source link

performance improvement #21

Closed rodrigogs closed 7 years ago

rodrigogs commented 8 years ago

You don't need to get the element each time square_am_signal is called. DOM access is not that fast, reducing access to it saves a lot of performance.

rocketinventor commented 7 years ago

@fulldecent This pull request should be closed now, as #30 includes this change and solves the conflicts. @rodrigogs Thanks for the tip and your contributions. Not as much of a performance boost as you would think but, a good call nonetheless.

fulldecent commented 7 years ago

Thank you!