search

fulldecent / system-bus-radio

Transmits AM radio on computers without radio transmitting hardware.
https://fulldecent.github.io/system-bus-radio/
MIT License
6.19k stars 386 forks source link

Updated song parser for JS #24

Closed rocketinventor closed 7 years ago

rocketinventor commented 8 years ago

Based on the work of pull request #1 ("Quick and dirty song parser...") by @lberezy...

A textbox has been added to the HTML to allow for the editing of what gets played back. The smb.song file has also been included and can be played back by copying and pasting it into the textbox. Everything from #1 except for the "delay" command has been implemented. (JS doesn't really have a good way to do that.)

This pull request also makes various fixes to the code of the Vanilla JS port including undefined vars, code spacing, etc.

rocketinventor commented 8 years ago

@fulldecent Is there any plan of getting this meged?

fulldecent commented 7 years ago

Blocker #28

rocketinventor commented 7 years ago

@fulldecent So, if I change over to the new format, it will get merged?

fulldecent commented 7 years ago

Yes! Sorry for the delay. Just wanted to prevent rework.

rocketinventor commented 7 years ago

@fulldecent The new files should be ready for a merge, and are compliant with the new song language from #28. I made the changes right away but, I hadn't realized that they never got committed.

rocketinventor commented 7 years ago

@fulldecent Is everything good to go?

fulldecent commented 7 years ago

Looks great, thank you. Merged!

rocketinventor commented 7 years ago

Ok, great! Thanks! P.s. Improvements to the CSS and JS coming soon!

fulldecent commented 7 years ago

Nice!