fulldotdev / ui

The Astro UI library to build content sites

https://ui.full.dev

MIT License

239 stars 12 forks source link

Grid style enhancments #55

Closed JagritGumber closed 1 month ago

JagritGumber commented 1 month ago

Changes/Additions being made

The grid component now uses auto-fill for styling instead of auto-fit

What's the context?

Style changes

Rationale behind the change or addition

Helps control the overflow of images in grid

Test plan

Tested it with 20 to 30 cards with varying number of cards and it works as intended

Screenshots (optional)

Before

After

Quality check

[x] Are there any erroneous console logs, debuggers or leftover code in your changes? No

netlify[bot] commented 1 month ago

Deploy Preview for fulldev-ui ready!

Name	Link
Latest commit	11c5a7b70c603a9b353cbd403ffa1c33f64d75c4
Latest deploy log	https://app.netlify.com/sites/fulldev-ui/deploys/66f2d27e62da8d000893ec4c
Deploy Preview	https://deploy-preview-55--fulldev-ui.netlify.app
Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

JagritGumber commented 1 month ago

Sorry about the commit being from Rakshit Gumber I maybe didn't set up the SSH properly.

silveltman commented 1 month ago

Thanks @JagritGumber

Looking at it now I realise why we used auto-fit. Please have a look at https://deploy-preview-55--fulldev-ui.netlify.app/blocks/features/

This block should use auto-fit instead of auto-fill. However, I do agree that for a component named "Grid" auto-fill is better.

What I will do is create a branche in which I add a new structure component called Stack.astro. Blocks like Features will use this stack structure, so we can merge this PR and use auto-fill for the Grid