search

fulls1z3 / ngx-meta

Dynamic page title & meta tags utility for Angular (w/server-side rendering)
MIT License
333 stars 47 forks source link

Default fallback on null instead of error (unless not defined in configuration) #190

Closed logan-jobzmall closed 4 years ago

logan-jobzmall commented 5 years ago

I'm submitting a ... (check one with "x")

[ ] Regression (a behavior that used to work and stopped working in a new release)
[ ] Bug report  <!-- Please check the repository for a similar issue or PR before submitting -->
[ ] Support request => <!-- Please check the repository for a similar issue or PR before submitting -->
[X] Feature request
[ ] Documentation issue or request

Current behavior

If you set a tag to null, it errors out. setTag('description', null) or setTag('og:description', null)

Expected/desired behavior

If value set is null (backend returns undefined value, or something of that nature), the default in your configuration object should be chosen instead of erroring. Only error if that is not set.