fulls1z3 / ngx-meta

Dynamic page title & meta tags utility for Angular (w/server-side rendering)
MIT License
334 stars 47 forks source link

Allow use of ngx-meta in angular 8 project #193

Closed mthomasson closed 4 years ago

mthomasson commented 5 years ago

I'm submitting a ... (check one with "x")

[ ] Regression (a behavior that used to work and stopped working in a new release)
[ ] Bug report  <!-- Please check the repository for a similar issue or PR before submitting -->
[ ] Support request => <!-- Please check the repository for a similar issue or PR before submitting -->
[x] Feature request
[ ] Documentation issue or request

Current behavior Using the current version generates warnings in the console:

warning " > @ngx-meta/core@7.0.0" has incorrect peer dependency "@angular/core@>=7.0.0 <8.0.0".
warning " > @ngx-meta/core@7.0.0" has incorrect peer dependency "@angular/platform-browser@>=7.0.0 <8.0.0".
warning " > @ngx-meta/core@7.0.0" has incorrect peer dependency "@angular/platform-browser-dynamic@>=7.0.0 <8.0.0".
warning " > @ngx-meta/core@7.0.0" has incorrect peer dependency "@angular/router@>=7.0.0 <8.0.0".

Expected/desired behavior Have a version tha points toward angular 8

Minimal reproduction of the problem with instructions

What is the motivation/use case for changing the behavior? Want to upgrade an Angular 7 project to Angular 8. Environment

rafa-suagu commented 5 years ago

some news @fulls1z3 ?

bjornharvold commented 5 years ago

Yes please

fulls1z3 commented 4 years ago

done