fulls1z3 / ngx-meta

Dynamic page title & meta tags utility for Angular (w/server-side rendering)
MIT License
333 stars 47 forks source link

feat(package): migrate to ng9 #207

Closed fulls1z3 closed 4 years ago

fulls1z3 commented 4 years ago

** PR Checklist Please check if your PR fulfills the following requirements:

** PR Type What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[x] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

** What is the current behavior?

Issue Number: N/A

** What is the new behavior?

** Does this PR introduce a breaking change?

[x] Yes
[ ] No

** Other information

BREAKING CHANGE

codecov[bot] commented 4 years ago

Codecov Report

Merging #207 into master will decrease coverage by 0.64%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #207      +/-   ##
==========================================
- Coverage   99.40%   98.75%   -0.65%     
==========================================
  Files           7        7              
  Lines         167      161       -6     
  Branches       50       47       -3     
==========================================
- Hits          166      159       -7     
- Misses          1        2       +1     
Impacted Files Coverage Δ
packages/@ngx-meta/core/src/meta.module.ts 83.33% <ø> (-9.53%) :arrow_down:
packages/@ngx-meta/core/src/meta.guard.ts 100.00% <0.00%> (ø)
packages/@ngx-meta/core/src/meta.loader.ts 100.00% <0.00%> (ø)
packages/@ngx-meta/core/src/meta.service.ts 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update da515f3...f56e182. Read the comment docs.

ghost commented 4 years ago

Warnings are found on analyzing the commit f56e182e30a3f5d39280e54a1aaa7339191c3e65.

2 warnings:

We recommend to address them as possible, for example, update outdated dependencies, fix the tool's configuration, configure sider.yml, turn off unused tools, and so on.

If you are struggling with these errors or warnings, feel free to ask us via chat. 💬