fulls1z3 / ngx-meta

Dynamic page title & meta tags utility for Angular (w/server-side rendering)
MIT License
333 stars 47 forks source link

changing language doesn't refresh meta (ng-seed/spa does because it reload the page!) #53

Closed Tuizi closed 4 years ago

Tuizi commented 7 years ago

I'm submitting a ... (check one with "x")

[x] bug report => check the README and search github for a similar issue or PR before submitting
[ ] support request => check the README and search github for a similar issue or PR before submitting
[ ] feature request

Current behavior

When you change the language, the translation on your page will change, but the title of the page will remains the same.

Expected/desired behavior As the content of your page change when you call this.translate(lang), the meta should also change.

Minimal reproduction of the problem with instructions You can reproduce this issue in the ng-seed/spa project if you remove the reload of the page (triggered by the this.router.navigate(['/']) or this.i18nRouter.changeLanguage(languageCode);).

The title will remains the same.

What is the motivation / use case for changing the behavior? The title of the tab should be in the language selected by the user as the content does.

fulls1z3 commented 7 years ago

@Tuizi thanks for pointing this out, we have a more or less similar open issue about this (#49), so I think things will work together.

Tuizi commented 7 years ago

Yeay! I'm thinking of starting helping you, all the libraries ngx-* are amazing.

fulls1z3 commented 7 years ago

@Tuizi really appreciate that you liked and utilized features from those libraries, and the community would be really glad from your contributions.

Meanwhile, more is coming: such as integrating @angular/material2 to ng-seed, d3.js and datatables implementation for material design.

Constantinos-Impact commented 5 years ago

Any updates on the issue?