fulls1z3 / universal

Seed project for Angular Universal apps featuring Server-Side Rendering (SSR), Webpack, CLI scaffolding, dev/prod modes, AoT compilation, HMR, SCSS compilation, lazy loading, config, cache, i18n, SEO, and TSLint/codelyzer
http://ng-seed.fulls1z3.com
MIT License
704 stars 138 forks source link

refactor(core): migrate to ng9 #743

Closed fulls1z3 closed 4 years ago

fulls1z3 commented 4 years ago

** PR Checklist Please check if your PR fulfills the following requirements:

** PR Type What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[x] Refactoring (no functional changes, no api changes)
[x] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

** What is the current behavior?

Issue Number: N/A

** What is the new behavior?

** Does this PR introduce a breaking change?

[ ] Yes
[x] No

** Other information

ghost commented 4 years ago

Warnings are found on analyzing the commit deae80ce5b25b2d181a73cffb25357f0fd6ece17.

3 warnings:

We recommend to address them as possible, for example, update outdated dependencies, fix the tool's configuration, configure sider.yml, turn off unused tools, and so on.

If you are struggling with these errors or warnings, feel free to ask us via chat. 💬

codecov[bot] commented 4 years ago

Codecov Report

Merging #743 into master will decrease coverage by 3.92%. The diff coverage is 87.09%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #743      +/-   ##
==========================================
- Coverage   91.59%   87.66%   -3.93%     
==========================================
  Files          84       84              
  Lines         928      884      -44     
  Branches       74       59      -15     
==========================================
- Hits          850      775      -75     
- Misses         78      109      +31     
Impacted Files Coverage Δ
.../shared/store-account/src/lib/auth/auth.actions.ts 100.00% <ø> (ø)
libs/shared/store/src/lib/store.module.ts 58.33% <0.00%> (-10.90%) :arrow_down:
.../shared/util-analytics/src/lib/analytics.module.ts 76.92% <0.00%> (-8.80%) :arrow_down:
libs/shared/util-core/src/lib/core.module.ts 63.63% <0.00%> (-5.93%) :arrow_down:
libs/shared/util-i18n/src/lib/i18n.module.ts 58.33% <0.00%> (-10.90%) :arrow_down:
...l/airline/airline-table/airline-table.component.ts 95.65% <100.00%> (+0.19%) :arrow_up:
...niversal/src/app/layout/header/header.component.ts 90.00% <100.00%> (-6.00%) :arrow_down:
apps/universal/src/app/login/login.component.ts 75.00% <100.00%> (-15.00%) :arrow_down:
.../shared/store-account/src/lib/auth/auth.effects.ts 96.55% <100.00%> (+0.12%) :arrow_up:
libs/shared/ui-material/src/lib/material.module.ts 100.00% <100.00%> (ø)
... and 36 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 9d1d3e3...e7e3779. Read the comment docs.