search

fullscale / elastic.js

A JavaScript implementation of the elasticsearch Query DSL
http://docs.fullscale.co/elasticjs/
MIT License
654 stars 163 forks source link

Bower support seems off #25

Closed ghost closed 11 years ago

ghost commented 11 years ago

So on a project I just did bower install elastic.js, and got most of the repo copied, with the exception of the dist folder, which in this case is the only one I actually care about. This is on bower 0.9.2, and it got v 1.1.1 of elastic.js.

mattweber commented 11 years ago

Can you please try again? I just tested and the dist folder with the expected files were pulled in just fine.

ghost commented 11 years ago

You're right, hmm, that's unfortunate though, my sublime project is ignoring dist as that's what the default Angular project uses for the release build, so .tmp and dist are ignored to make the project reasonable. Would you be open to changing the folder structure at all? As far as bower goes, I find it really nice with layouts like lodash and angular, whereas they have what you have in the dist folder and in bower.json ignore literally everything else, which I think is typically what most people expect when using it.

mattweber commented 11 years ago

Unfortunately no. It looks like angular created a separate repository specifically for bower. I might be able to do something like this for the next release.

ghost commented 11 years ago

No worries, I'm fine now that I know it's there, just got thrown off by it being missing. I think the contents may be part of a bigger question around bower. More or less, are we expected to add the components to source control or not. If so, I think this structure is a bit heavy.

ghost commented 11 years ago

One interesting option seen here is to make the dist folder a subrepository. That way people can still clone the full thing, still download directly from GitHub, but the Bower link would point to the subrespository. https://github.com/stackfull/angular-virtual-scroll