Open bmorrisondev opened 1 year ago
I began working on this today. Let me know if you want me to continue working in this direction. I fear I may be making this more complicated than it needs to be.
body
styles in global.css
on the main
element in the index.tsx
file.p
or a
is on the page.You can see those commits below. I was planning on completing all before issuing a PR, but let me know if you would rather I do one sooner than that.
Ok a few things:
body
, h1
, etc...) in global.css and either use the @apply
directive or just normal CSS. No need to create separate components for them. Something like button
is an exception because those usually have alot of styling on them, so they can be their own components..layout
) should have a component with the necessary tailwind classes. The upstream main
branch has a <Layout>
component for exactly this, so once you merge in from the upstream we can scrap the layout class altogether, was just using it as an example.hover:
directive to alter styles based on hover state (and disabled:
too). So no need to use state with string manipulation to modify hover styles. For ex, if I have text and I use text-red-900 hover:text-red-400
, the text will be red-900 by default and red-400 when hovered.ExternalLink
component, React supports passing in nested stuff to a component using the children
prop name with the ReactNode
type:type Props = {
children: ReactNode
}
function MyComp({ children }: Props) {
<div>
{ children }
</div>
}
@ryanfurrer hold on this for now, looking to implement a completely update design.
@ryanfurrer hold on this for now, looking to implement a completely update design.
Can do. I would be happy to jump back in or help implement the redesign if my schedule allows it.
Lots of OG CSS in the global styles file.