search

fullstack-hy2020 / part2-notes

69 stars 180 forks source link

Package.json scripts added to frontend instead of backend #70

Open ananta-dev opened 2 years ago

ananta-dev commented 2 years ago

The following lines have been added to the frontend package.json:

    "build:ui": "rm -rf build && cd ../part2-notes/ && npm run build && cp -r build ../notes-backend",
    "deploy": "git push heroku main",
    "deploy:full": "npm run build:ui && git add . && git commit -m uibuild && git push && npm run deploy",    
    "logs:prod": "heroku logs --tail"

I believe they should have been added to the backend package.json instead.

ananta-dev commented 2 years ago

This may be useful as reference: https://fullstackopen.com/en/part3/deploying_app_to_internet#streamlining-deploying-of-the-frontend

DanyBeth-Dev commented 1 year ago

yes I saw that too so I'm confused where they must be, maybe the creator has not seen this @mluukkai