Follow issue5 of gongleaflet

thomaspeugeot commented 2 years ago

Steps:

[ ] use embed compilation for angular
[ ] change dependency to issue5
[ ] port

thomaspeugeot commented 2 years ago

cannot compile

ERROR in ../vendor/github.com/fullstack-lang/gongleaflet/ng/projects/gongleafletspecific/src/lib/cartoatc/cartoatc-centers/cartoatc-centers.component.ts:8:20 - error TS7016: Could not find a declaration file for module 'leaflet'. '/Users/thomaspeugeot/go/src/github.com/fullstack-lang/gongfly/ng/node_modules/leaflet/dist/leaflet-src.js' implicitly has an 'any' type.
  If the 'leaflet' package actually exposes this module, consider sending a pull request to amend 'https://github.com/DefinitelyTyped/DefinitelyTyped/tree/master/types/leaflet'

8 import * as L from 'leaflet'

This is strange since the tsconfig.json is with

      "@types/leaflet": [
        "./node_modules/@types/leaflet"
      ],
      "@asymmetrik/ngx-leaflet": [
        "./node_modules/@asymmetrik/ngx-leaflet"
      ],
      "leaflet": [
        "./node_modules/leaflet"
      ],

Let's try another order. Does not work.

how to list the path for modules ?

thomaspeugeot commented 2 years ago

add

      "@types/node": [
        "./node_modules/@types/node"
      ],

not working

thomaspeugeot commented 2 years ago

in gongleaflet, where the compilation is working,

leaflet declaration is mentioned in

module "/Users/thomaspeugeot/go/src/github.com/fullstack-lang/gongleaflet/ng/node_modules/@types/leaflet/index"

Let's see is the directory exists in gongfly

thomaspeugeot commented 2 years ago

Still the problem

Could not find a declaration file for module 'leaflet'. '/Users/thomaspeugeot/go/src/github.com/fullstack-lang/gongfly/ng/node_modules/leaflet/dist/leaflet-src.js' implicitly has an 'any' type.

Maybe this is the configuration with 'do not check library'

Task : understand what is

[x] what is Ivy ?
[ ] what is tsconfig.lib.jsoon. Should it be edited for the path to leaflet ?
[ ] what is the tsconfig.lib.prod.json ? is it usefull ? Is the "enableIvy": false a problem for the compilation. It is used only there is a publication later
[ ] can the angular file be compiled independently by the ts compiler ?
[ ] how is the 'import' instruction is processed by the ts compiler ?

what is Ivy ?

"https://blog.ninja-squad.com/2019/05/07/what-is-angular-ivy/"

That’s why a big part of Angular is its compiler: it takes all your HTML and generates the necessary JS code. This compiler (and the runtime) has been completely rewritten over the last year, and this is what Ivy is about. This is not the first rewrite: Ivy stands for ‘IV’, 4 in roman numbers. The last rewrite was done in Angular 4.0, and maybe you did not even noticed i

No, I did not

If I uncheck // "strict": true,, compilation is OK.

thomaspeugeot commented 2 years ago

../vendor/github.com/fullstack-lang/gongdoc/ng/projects/gongdocdiagrams/src/lib/class-diagram/class-diagram.component.ts:2:0-33 - Error: Module not found: Error: Can't resolve 'jointjs' in 'D:\MOSS-Users\peugeot\go\src\github.com\fullstack-lang\gongfly\vendor\github.com\fullstack-lang\gongdoc\ng\projects\gongdocdiagrams\src\lib\class-diagram'

this is new for windows. something not seen in the mac version.

fullstack-lang / gongfly

Follow issue5 of gongleaflet #1