search

fullstackhero / dotnet-starter-kit

Production Grade Cloud-Ready .NET 8 Starter Kit (Web API + Blazor Client) with Multitenancy Support, and Clean/Modular Architecture that saves roughly 200+ Development Hours! All Batteries Included.
https://fullstackhero.net/dotnet-webapi-boilerplate/
MIT License
5.19k stars 1.56k forks source link

Refresh token missing property #128

Closed markosimulak closed 2 years ago

markosimulak commented 2 years ago

Hi :)

Bug description

While working with refresh token, I've found out that in GetPrincipalFromExpiredToken() function, property ValidateLifetime should be set to false when creating TokenValidationParameters instance.

How to fix

  1. Go to https://github.com/fullstackhero/dotnet-webapi-boilerplate/blob/d907cacdb6534fe1053ced6da0fc2a5c869df013/src/Infrastructure/Identity/Services/TokenService.cs#L169
  2. Extend tokenValidationParameters variable with ValidateLifetime = false
iammukeshm commented 2 years ago

Could you please make the changes and raise a pull request for it? I will merge it.

iammukeshm commented 2 years ago

Please pull the latest code and commit your changes. Thanks

markosimulak commented 2 years ago

Sure, no problem.