search

fullstackproltd / AspNetCoreSpa

Asp.Net 7.0 & Angular 15 SPA Fullstack application with plenty of examples. Live demo:
https://aspnetcorespa.fullstackpro.co.uk
MIT License
1.47k stars 464 forks source link

translations through csv #238

Closed asadsahi closed 6 years ago

asadsahi commented 6 years ago

@SanyaBogos have a look at this PR, this one is simpler but achieving the same goal of managing translations through csv file. ClientSide still needs to wire up with translations, but can be done at some point.

Key things to note is that we dont' need to rely on any external csv parser package. simple file reading is enough. no hardcoded string of cultures. All managed through file. Right now there are only two cultures but can easily be extended for any more cultures.

Let me know what do you think or if anything is missing before I merge into master.

Thanks

SanyaBogos commented 6 years ago

@asadsahi yep, great idea to get rid of hardcoded cultures. Idea using simple reading instead of csv reader also look good. As for me, cool, but I see, for now you don't apply translations for login or register components, right? Are you going to create another pull request for this?

asadsahi commented 6 years ago

@SanyaBogos I'll update rest of client side content sooner.