Closed rbianco3 closed 5 years ago
rbianco3
commented
5 years ago P.S. If you can guide me I'd like to help w/ the project & you can assign to me but I may need a little hand holding but will continue to help w/ the project as I'm taking a break from my IT contract for holidays.
asadsahi
commented
5 years ago @rbianco3 sorry for the delay.
Thanks for raising this issue. I have catered some of the clarifications in readme with some other fixes. Have a look and let me know if you find anything else which needs clarification.
Thanks for your offer. There is always help/improvement required. Test coverage is low in this project and would love to have some unit tests written. Happy to accept any PR which will help improving this project.
Thanks once again.
asadsahi
commented
5 years ago BTW, there is already an open issue which targets unit tests:
Errors at npm start command after following instructions exactly. Windows 10 on Intel Visual Studio 2017 Node v9.5.0 NPM v5.6.0
1st Error indicated Angular CLI was missing so I think it should be added to Requirements. 2nd Error indicated Typescript was needed but missing. 3rd Error for which I could not solve was on "Build" message said "Docker for Windows" must be installed. I noticed Docker requires Hyper-V for which I don't use. So unable to run or help w/ project too bad it looks really nice. Also npm start fails with other errors after fixing above: C:\Users\displ\source\repos\AspNetCoreSpa\src\AspNetCoreSpa.Web\ClientApp>npm start
internal/modules/cjs/loader.js:589 throw err; ^
Error: Cannot find module 'C:\Users\displ\source\repos\AspNetCoreSpa\src\AspNetCoreSpa.Web\ClientApp\node_modules\angular-cli\bin\ng'
I would have fixed it myself but not able to get it running and just spinning wheels. Thank you.