fullstackreact / google-maps-react

Companion code to the "How to Write a Google Maps React Component" Tutorial
https://www.fullstackreact.com/articles/how-to-write-a-google-maps-react-component/
MIT License
1.64k stars 818 forks source link

The latest 2.0.2 doesn't work #266

Open miliu99 opened 6 years ago

miliu99 commented 6 years ago

I just got the latest in hoping to get the Circle support, but it doesn't work. I gueess somebody made mistake when merging the Circle request?

Nalipp commented 6 years ago

I also was unable to load the circle request. When I import Marker I can print the function. When I import Circle I can only print undefined.

jackpilowsky commented 6 years ago

When I run npm install --save google-maps-react, there is no circle component and no circle is defined in dist/index.js.

If I remove google-maps-react and then navigate to the node_modules directory and run git clone https://github.com/fullstackreact/google-maps-react.git, it works. But I have to redo this process every time I run npm install

ZHamburglar commented 6 years ago

When running npm install --save google-maps-react It looks like the Circle isn't included in the list of Components with google-maps-react. Only HeatMap, InfoWindow, Marker, Polygon, and Polyline. But this repo includes the Circle component.

jackpilowsky commented 6 years ago

I submitted a pull request just now to bump the version to 2.0.3 and publish the new version to NPM. That should bring along the Circle component into the npm install

blakedietz commented 5 years ago

Any updates on as to whether or not there's going to be a release of the Circle component?

jackpilowsky commented 5 years ago

They merged the pull request but havent published it to NPM yet. There is a workaround to grab the package from github. In your package.json use:

"google-maps-react": "git://github.com/fullstackreact/google-maps-react/commit/5c4902ca25706ee1b8de756a6d318daf7d0e0080",
blakedietz commented 5 years ago

Hrm, is there any interest in creating an automated release pipeline? I would be willing to set up semantic release and a ci pipeline that supports open source builds for free. It would be great to not have to wait for releases after code has been merged to master.

miliu99 commented 5 years ago

it is strange that it works fine in dev mode, but not in production mode - I got "Minified react error #130".

Dianoga commented 5 years ago

It looks like this would benefit greatly from an automated pipeline like @blakedietz suggested. I'm guessing that would need someone from @fullstackreact to get up and running though.

KlausFabian commented 5 years ago

I see the circle code, but the CIRCLE example from the READ.ME throws an error. The Polygon example also did not have the correct view port - I got it from the Google example then it worked. But I always get an exception with the circle: Warning: React.createElement: type is invalid -- expected a string (for built-in components) or a class/function (for composite components) but got: undefined. You likely forgot to export your component from the file it's defined in, or you might have mixed up default and named imports.

israelsaraiva commented 5 years ago

any changes about this issue?

miliu99 commented 5 years ago

It appears to me that this package is no more maintained. So I switched to google-map-react (without s) which works well.

Sent from my iPhone X

On Jul 4, 2019, at 5:46 AM, Israel Souza Saraiva notifications@github.com wrote:

any changes about this issue?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.

Ciip1996 commented 5 years ago

Perhaps you should consider following this solution. I can confirm it works for me :D

https://github.com/fullstackreact/google-maps-react/issues/300#issuecomment-451765622