Fix crash that happens when Firebase API key gets revoked

KrauseFx commented 7 years ago

Fixes https://github.com/fullstackreact/react-native-firestack/issues/318

This has been really hard to reproduce and track down: When an API key gets revoked the stored auth token is not valid any more, causing this error. error localizedFailureReason doesn't contain anything in that case, so it's nil, causing Objective-C to crash as you can't have it as a value for a dictionary.

It's probably save to have the default text here, but feel free to tweak it and modify the PR directly as necessary.

Let me know if you have any other questions. I'm using firestack for my side project wwdc.family :+1:

Salakar commented 7 years ago

@KrauseFx this has long since been fixed on my v3 fork, I re-wrote auth from scratch and it has better error handling and matching web SDK error codes.

I'd suggest moving over there for three reasons really:

It's a re-write from the ground up - it matches the firebase web SDK to the letter and it's well tested with a custom testing app. This repo has a ton of bugs / issues and the api is unruly in terms of no correlation between it and the official firebase web sdk.
It's well supported and documented, issues are answered daily and work is done on it daily. All 3 co-authors (myself included) are active on slack, gitter and discord answering questions daily - whereas this repo has long since been abandoned by it's authors.
Minimal disparity between platforms, features are built and tested on both android and ios before getting released. For example we now have remote config, transactions, perf-mon, analytics, crash and more in addition to the current firestack feature set.

Fork: https://github.com/Salakar/react-native-firestack

KrauseFx commented 7 years ago

@Salakar glad to hear. When do you think that will be part of master?

fullstackreact / react-native-firestack

Fix crash that happens when Firebase API key gets revoked #340