search

fullstackreact / react-native-oauth

A react-native wrapper for social authentication login for both Android and iOS
https://fullstackreact.com
MIT License
802 stars 216 forks source link

Typescript definitions #62

Open bufke opened 7 years ago

bufke commented 7 years ago

Would you be interested in typescript definitions for this project? I made a very basic one that I plan to add some details to.

auser commented 7 years ago

YES! Absolutely! Please make a fork/branch! #veryinterested

bufke commented 7 years ago

Ok I added them here https://github.com/bufke/react-native-oauth

They aren't complete yet. Comments/changes welcome. Improvements could include replacing more any's and marking which methods are public vs private.

I'm experienced with typescript but not with contributing d.ts files. @auser do you have a preference on having the type defs as part of this project or should I submit them to definitelytyped?

I tested the package by just dropping the files into another project's node_modules/react-native-oauth and tsc picked them up. Looks like people on definitelytyped also add tests which would be new for me.