fullstackreact / react-yelp-clone

Tutorial: Build a Yelp-clone in React
https://www.fullstackreact.com/articles/react-tutorial-cloning-yelp/
MIT License
840 stars 218 forks source link

isDev config now shared with isTest #13

Closed Joegrundman closed 8 years ago

Joegrundman commented 8 years ago

I have fixed a bug mentioned in this issue here which results in the tests failing with react 15.2.1 or more recent.

The problem is that as of react 15.2.1 react test-utils will no longer run in prod mode, and the webpack config has isTest not sharing all isDev configuration. I have made a fix so that now isTest will share all isDev config. You can see on line 21 of webpack.config.js on the branch react15_2_1_test_compat

Tests will now pass successfully with react15.2.1.

I think it would be useful to pull this into the repository, and also maybe the tutorial should be updated to reflect this change

best wishes

joegrundman