Rename views to be friendlier for namespace pollution - Githubissues

fullstorydev / dbt_fullstory

The official FullStory dbt package

Apache License 2.0

2 stars 3 forks source link

Rename views to be friendlier for namespace pollution #4

Closed craigrmccown closed 1 year ago

craigrmccown commented 1 year ago

Problem

The terms users and sessions are generic enough that they may conflict with existing or future views in the destination BigQuery dataset.

Changes

New vars have been introduced that can be used to override the session and user view names.
By default, the users and sessions views are aliased using the same pattern as the events table for both BigQuery and Snowflake. Because we use a dedicated schema, Snowflake identifiers remain unchanged.
Seeds have been renamed to take a fullstory_ prefix in both Snowflake and BigQuery.

Caveats

The formatting macro invocation for BigQuery identifiers has been copied twice. I am not aware of a way to define and use macros within YAML configuration files. This discussion is relevant, but I don't see any resolution.
Seeds technically don't need to be renamed for Snowflake because we already use a schema. However, I've opted to rename them across the board for simplicity and consistency.

camphillips22 commented 1 year ago

@craigrmccown maybe rebase to get circle file?