search

fullstorydev / fullstory-babel-plugin-annotate-react

A Babel plugin that annotates React components, making them easier to target with FullStory search
MIT License
30 stars 13 forks source link

skip known-incompatible node modules #99

Closed JoshMiers-FS closed 2 years ago

JoshMiers-FS commented 2 years ago

There are certain node modules that we know are incompatible with our annotate plugin. They either reuse the dataElement attribute for their own purpose (VictoryLib) or disallow extra attributes on their object (https://github.com/react-navigation/react-navigation).

This PR adds functionality to have a hardcoded blocklist that we will maintain as needed.

JoshMiers-FS commented 2 years ago

cc @nfriedly

mikewli commented 2 years ago

@JoshMiers-FS So why is react-native-navigation blacklisted? Is it because it doesn't allow us to append the dataElement prop to components, like react-navigation?

mikewli commented 2 years ago

Yeah, I can live with this.

It might be beneficial to add a comment for each blocked package about why we're blocking it and perhaps which version we tested. (One comment for all of victory* is fine, though)

Totally agree, since (we may forget why we're / new members on the team may not understand why we're) blocking the library especially the list gets long and/or we haven't touched that library for some time.

nfriedly commented 2 years ago

BTW, I can now be assigned PRs for this repo