fullstorydev / fullstory-browser-sdk

Official FullStory SDK for JavaScript, for web browsers
MIT License
55 stars 17 forks source link

Fix ES Module Output #10

Closed timjchin closed 5 years ago

timjchin commented 5 years ago

This PR makes two changes:

patrick-fs commented 5 years ago

@timjchin Interesting observation about the output value. I actually used rollup's own lib example config as the basis for my own: https://github.com/rollup/rollup-starter-lib/blob/master/rollup.config.js

image

I've verified as well that the resulting build artifact (dist/index.js) does indeed export a default module:

image

Having said that, it's possible that the rollup example is stale. I'll update the config per the docs (and may even to a PR for rollup's example).

timjchin commented 5 years ago

Closing this in favor of https://github.com/fullstorydev/fullstory-browser-sdk/pull/11!