search

fullstorydev / fullstory-browser-sdk

Official FullStory SDK for JavaScript, for web browsers
MIT License
55 stars 17 forks source link

updating the SNIPPET_ENDPOINT env var to point to the prod snippet API #31

Closed patrickbrandt closed 4 years ago

patrickbrandt commented 4 years ago

The production /code/v1/snippet endpoint is live! this PR updates the GitHub Action to poll the prod endpoint.

ian0608 commented 4 years ago

Looks like the PR is still "owned" by @patrickbrandt rather than @patrick-fs ? Is the commit going to be attributed to @patrickbrandt in the repo history? I'm not sure how the mechanics work in GH. :/

patrick-fs commented 4 years ago

Looks like the PR is still "owned" by @patrickbrandt rather than @patrick-fs ? Is the commit going to be attributed to @patrickbrandt in the repo history? I'm not sure how the mechanics work in GH. :/

Hey @ian0608 no, the commit will be attributed to patrick-fs: image

TBH, it's a little weird that @patrickbrandt was able to create a PR.

Having said that, I'm not worried about having @patrickbrandt be the owner of the PR.