search

fullstorydev / grpchan

Channels for gRPC: custom transports
MIT License
205 stars 23 forks source link

protoc-gen-grpchan should append "Server" to Register function #14

Closed RangelReale closed 6 years ago

RangelReale commented 6 years ago

First great work on this library, it is awesome!

protoc-gen-grpchan generates the server registration without "Server" at the end of the function name, like the protoc-gen-go does, I think it may be better to keep this consistency.

jhump commented 6 years ago

This was intentional to keep the generated function names from being overly long. The thinking was that Handler in the generated names is sufficient to indicate that this is for server-side.