search

fullstorydev / grpchan

Channels for gRPC: custom transports
MIT License
204 stars 23 forks source link

use go 1.13 to run vet tools; update go.mod w/ all indirect references used by CI #43

Closed jhump closed 4 years ago

jhump commented 4 years ago

I'm not sure why this suddenly started breaking with Go 1.11, but running CI checks with Go 1.13 seems to resolve the issue.

While at it, I also updated go.mod (and go.sum) to include all indirect references -- to tools/packages that are used during the CI checks.

jhump commented 4 years ago

what did you run to get the indirect refs in?

I ran make ci. That runs all of the checks locally, when includes doing some go get ... to get the tools. When you do go get ... inside of a Go module, the Go tool automatically pins the version it finds in your go.mod file as an indirect dependency. So running that locally is all I had to do.

dragonsinth commented 4 years ago

I ran make ci. That runs all of the checks locally, when includes doing some go get ... to get the tools. When you do go get ... inside of a Go module, the Go tool automatically pins the version it finds in your go.mod file as an indirect dependency. So running that locally is all I had to do.

Ahh, thank you.