This deprecates the Channel interface and the generated New<Service>ChannelClient functions. It also fixes up all usage of context (to stop importing golang.org/x/net/context).
I also re-generated all files using proper pinned version of protoc-gen-go and made some fixes identified by go vet related to failing to call a context's cancel function. Strangely, the versions in the repo had full paths, relative to a GOPATH. Yet the actual go:generate directive would generate files with no directories at all. To prevent accidental issues with registering duplicate files (since test.proto, without a path, seems to generic and easy to have a collision), I tweaked that directive so the file is registered as grpchantesting/test.proto instead.
Finally, there are some changes to the Makefile, to get it inline with recent-ish changes made to the Makefile in other repos (like grpcurl and grpcui).
This deprecates the
Channel
interface and the generatedNew<Service>ChannelClient
functions. It also fixes up all usage ofcontext
(to stop importinggolang.org/x/net/context
).I also re-generated all files using proper pinned version of
protoc-gen-go
and made some fixes identified bygo vet
related to failing to call a context's cancel function. Strangely, the versions in the repo had full paths, relative to aGOPATH
. Yet the actualgo:generate
directive would generate files with no directories at all. To prevent accidental issues with registering duplicate files (sincetest.proto
, without a path, seems to generic and easy to have a collision), I tweaked that directive so the file is registered asgrpchantesting/test.proto
instead.Finally, there are some changes to the
Makefile
, to get it inline with recent-ish changes made to theMakefile
in other repos (like grpcurl and grpcui).