search

fullstorydev / grpchan

Channels for gRPC: custom transports
MIT License
205 stars 23 forks source link

use legacy_stubs option, so we don't remove an exported method from the API #48

Closed jhump closed 3 years ago

jhump commented 3 years ago

Well crap.

I had this in the last branch (#47) but apparently failed to push this last commit :/

Without this, we've removed an exported symbol from a non-internal package, which is technically a breaking change. And it happens to break trying to upgrade our mn repo since we have some tests that use grpchantesting and that symbol (NewTestServiceChannelClient)

So this fixes it to restore backwards compatibility.

dragonsinth commented 3 years ago

🎉 🎉 🎉