search

fullstorydev / grpcurl

Like cURL, but for gRPC: Command-line tool for interacting with gRPC servers
MIT License
10.36k stars 497 forks source link

Bump github.com/jhump/protoreflect from 1.13.0 to 1.14.0 #343

Closed dependabot[bot] closed 1 year ago

dependabot[bot] commented 1 year ago

Bumps github.com/jhump/protoreflect from 1.13.0 to 1.14.0.

Release notes

Sourced from github.com/jhump/protoreflect's releases.

v1.14.0

"github.com/jhump/protoreflect/dynamic"

Changes/fixes:

  • If converting or merging a generated message into a *dynamic.Message, if the generated message contained dynamic extensions (extension fields not known to the Protobuf runtime's global registry), they would be lost during the conversion. This has been fixed.

"github.com/jhump/protoreflect/grpcreflect"

Additions:

  • Adds a new grpcreflect.NewClientAuto method, which returns a client that will automatically use either the v1 version of server reflection or v1alpha, depending on what the server supports.
  • Adds a new grpcreflect.NewClientAlpha method which is meant to replace grpcreflect.NewClient. It always uses the v1alpha version of server reflection (and its predecessor, grpcreflect.NewClient, is now deprecated since it is unclearly named).
Commits
  • 3b27be2 grpcreflect supports v1 of the reflection service (#535)
  • ac1361c update protoc to 21.7; also adds go 1.19 to CI (#534)
  • 101791c gofmt 1.19; add support for v2 extendable messages in *dynamic.Message (#533)
  • See full diff in compare view


Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
dragonsinth commented 1 year ago

@jhump fyi copied in some Makefile updates from other projects to modernize for updated Go. Also spot-fixed some test and a couple golint things, but didn't add golint into the chain.

jhump commented 1 year ago

@dragonsinth, ack! LGTM

jhump commented 1 year ago

FWIW, we only ran tests (and not the other targets in make ci) for most versions of Go and did the rest of the CI checks with a single "blessed" version of Go, since there would occasionally be incompatibilities such you couldn't get a clean run on multiple go versions. For example, if something this repo uses gets deprecated in a new version of Go, go vet in the new version reports it as a problem, but you can't actually change it or older versions might not even build. I'm slightly surprised this worked as I know Go 1.19 made some big changes to gofmt. But I guess the changes that gofmt in 1.19 wants to make are "stable" if an older gofmt is then used...

dragonsinth commented 1 year ago

Yeah, I think the updated gofmt changes are ok in old versions.