fullstorydev / grpcurl

Like cURL, but for gRPC: Command-line tool for interacting with gRPC servers
MIT License
10.36k stars 497 forks source link

Use protoset & reflection in the same time #351

Open mark4z opened 1 year ago

mark4z commented 1 year ago

can we ?

jhump commented 1 year ago

@mark4z, do you mean like described in issue #135 (and already implemented in #146 and first released in v1.6.0)?

mark4z commented 1 year ago

@jhump Yes, similar but needs to be a little smarter. That's because when some third-party proto dependencies are compiled by gogoprotoc, but you can't simply recompile it, like ‘k8s.io/api’, the current grpc reflection doesn't return the corresponding descriptors correctly because gogoprotoc doesn't register its own descriptors to grpc. so, here a possible solution is to actually merge the local descriptors with the descriptors returned by the reflection, even in find deps. Maybe I'll do that.