fullstorydev / grpcurl

Like cURL, but for gRPC: Command-line tool for interacting with gRPC servers
MIT License
10.36k stars 497 forks source link

Show additional error details when an rpc fails #379

Closed fdfzcq closed 1 year ago

fdfzcq commented 1 year ago

Fixes the following issue:

If an error is returned with additional details together with code and message, grpcurl will format it poorly and not show the additional details.

ghost commented 1 year ago
👇 Click on the image for a new way to code review #### [![Review these changes using an interactive CodeSee Map](https://s3.us-east-2.amazonaws.com/maps.codesee.io/images/github/fullstorydev/grpcurl/379/48639c65/e0ae376fbfaa12a46b5369a0ec8a929d7b096590.svg)](https://app.codesee.io/r/reviews?pr=379&src=https%3A%2F%2Fgithub.com%2Ffullstorydev%2Fgrpcurl) #### Legend CodeSee Map legend
fdfzcq commented 1 year ago

Hello @dragonsinth could you have a look at this small PR when you have time? Thank you!

fdfzcq commented 1 year ago

Hello @dragonsinth @jhump can we have this PR merged? :) thx!

fdfzcq commented 1 year ago

@dragonsinth thank you for merging the PR, could you make a new release too? :)