search

fullstorydev / grpcurl

Like cURL, but for gRPC: Command-line tool for interacting with gRPC servers
MIT License
10.36k stars 497 forks source link

grpcurl support for encoding formats other than UTF-8 #391

Closed ritwik12 closed 1 year ago

ritwik12 commented 1 year ago

Hey,

Need to confirm if grpcurl can support encoding/decoding of formats such as utf-8, utf-16, utf-16-le, utf-16-be

Is there any restriction in gprcurl which might be a blocker in supporting those functionalities?

jhump commented 1 year ago

@ritwik12, instead of adding features to grpcurl for text format processing, I think it would be better to instead use iconv to translate to utf8 and then pipe that to grpcurl.

ritwik12 commented 1 year ago

@jhump thanks for the suggestion, wanted to know if currently grpcurl supports encoding/decoding of other text formats or not?

jhump commented 1 year ago

@ritwik12, it does not. Under the hood, this uses Go's encoding/json package, which requires that the incoming text be UTF8-encopded. More context here.

ritwik12 commented 1 year ago

@jhump Thanks for clarifying