Fix nil-dereference panic that can happen invoking a server stream

fullstorydev / grpcurl

Like cURL, but for gRPC: Command-line tool for interacting with gRPC servers

MIT License

10.36k stars 497 forks source link

Fix nil-dereference panic that can happen invoking a server stream #395

Closed jhump closed 1 year ago

jhump commented 1 year ago

This should resolve #394.

The bidi and client streaming methods already had stream accesses behind a str != nil check. It was just server-side streaming that was missing these checks :(

jhump commented 1 year ago

@dragonsinth or @sanjaybv 👀

ghost commented 1 year ago

👇 Click on the image for a new way to code review

#### [![Review these changes using an interactive CodeSee Map](https://s3.us-east-2.amazonaws.com/maps.codesee.io/images/github/fullstorydev/grpcurl/395/64228bfd/2af4fd57342e54519787192872638911308c7af4.svg)](https://app.codesee.io/r/reviews?pr=395&src=https%3A%2F%2Fgithub.com%2Ffullstorydev%2Fgrpcurl) #### Legend CodeSee Map legend