TestBrokenTLS_ClientHasExpiredCert fail with golang-1.21

fullstorydev / grpcurl

Like cURL, but for gRPC: Command-line tool for interacting with gRPC servers

MIT License

10.36k stars 497 forks source link

TestBrokenTLS_ClientHasExpiredCert fail with golang-1.21 #405

Closed mikelolasagasti closed 10 months ago

mikelolasagasti commented 11 months ago

Building grpcurl 1.8.7 with golang-1.21 for Fedora Rawhide fails in the following test:

--- FAIL: TestBrokenTLS_ClientHasExpiredCert (0.01s)
    tls_settings_test.go:217: expecting TLS certificate error, got: remote error: tls: expired certificate

MyUmmaGumma commented 10 months ago

Similar error on Manjaro Linux, grpcurl 1.8.7-1 - installing via makepkg Is the fix to call ClientTransportCredentials(...,..., "internal/testing/tls/wrong-client.crt",...) instead of calling it with internal/testing/tls/expired.crt in tls_settings_test.go?

dragonsinth commented 10 months ago

https://github.com/fullstorydev/grpcurl/pull/408