search

fullstorydev / grpcurl

Like cURL, but for gRPC: Command-line tool for interacting with gRPC servers
MIT License
10.35k stars 497 forks source link

Added initial support for -t flag to show timings #428

Closed KaibutsuX closed 5 months ago

KaibutsuX commented 8 months ago

Shows very basic timing data for the Dial stage (TLS setup and BlockingDial) and InvokeRPC method as well as the total time.

KaibutsuX commented 8 months ago

Could we reduce the options by just making this part of -vv? We could just log e.g. "start Dial" -> "end Dial (35ms)" in the places where this PR is capturing time.Now() and time.Since()

I'm ok with that if you're ok with the timing data eventually becoming more verbose. Would there be any scenario in which someone would want verbose output but NOT want to see a big block of timing data?

dragonsinth commented 7 months ago

How much are we talking about? I assumed this would be kinda coarse grained timing on major steps.

On Fri, Nov 3, 2023, 1:27 PM KaibutsuX @.***> wrote:

Could we reduce the options by just making this part of -vv? We could just log e.g. "start Dial" -> "end Dial (35ms)" in the places where this PR is capturing time.Now() and time.Since()

I'm ok with that if you're ok with the timing data eventually becoming more verbose. Would there be any scenario in which someone would want verbose output but NOT want to see a big block of timing data?

— Reply to this email directly, view it on GitHub https://github.com/fullstorydev/grpcurl/pull/428#issuecomment-1792851239, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAOUVLCSZUDLQJJE5HEG5FDYCUSPHAVCNFSM6AAAAAA6W6GVFGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTOOJSHA2TCMRTHE . You are receiving this because you commented.Message ID: @.***>

KaibutsuX commented 7 months ago

I haven't dug into what further information I can get out of the connection, I assumed there might be finer grained details. But for now this at least gets me the information I was looking for to debug some slow responses from the a server. If you want this in -vv I can move it there.

dragonsinth commented 5 months ago

@KaibutsuX I pushed you a commit to clean this up a bit: WDYT?