search

fullstorydev / grpcurl

Like cURL, but for gRPC: Command-line tool for interacting with gRPC servers
MIT License
10.35k stars 497 forks source link

feat: introduce transparent client side health check #463

Closed violin0622 closed 1 month ago

violin0622 commented 1 month ago

gRPC can fetch ServiceConfig by DNS resolver. When ServiceConfig contains health check config, the client should import google.golang.org/grpc/health package to toggle its init() function, which sets the default healthcheck handler function.

Currently, grpcurl doesn't import it, leading service configuration does not take effect, and this MR aims to resolve it.

dragonsinth commented 1 month ago

🤷 seems harmless, @jhump you know about this feature?

jhump commented 1 month ago

Seems good to me 👍