search

fullstorydev / hauser

Service for moving your Fullstory export files to a data warehouse
MIT License
49 stars 23 forks source link

Respect 'Retry-After' property if defined in the 429 response #26

Closed butanian closed 6 years ago

butanian commented 6 years ago

This change makes it so if we encounter a 429 response when fetching export data, we parse the Retry-After property and respect the specified wait time before retrying.

A few constants were arbitrarily defined - # of retries and default wait Retry-After time if none is specified in the response. If you think there is value in having these constants sourced from the config, happy to move them there.

Changes were made to the vendor/github.com/nishanths/fullstory package. If the changes are acceptable here, I will make corresponding changes in the vendor package and reconcile.

butanian commented 6 years ago

PTAL

butanian commented 6 years ago

@jameremo yes to taking over the follow up PR! Would appreciate a cc so I can see what exactly you do for that!

sanjaybv commented 6 years ago

@butanian @jameremo We shouldn't have merged this PR with changes in the vendor dir, right? It was my understanding that we'd be merging this one after the changes to Nishanth's package was merged. I guess if we do this, we'll just have to use the "reconcile" option in gorepoman and dirty merge it when the PR in Nishanth's package does get merged.

butanian commented 6 years ago

@jameremo and I had discussed this. We decided to first change it in the hauser project and then reconcile with gorepoman at a later time.