Patrick/refactor config

fullstorydev / hauser

Service for moving your Fullstory export files to a data warehouse

MIT License

49 stars 23 forks source link

Patrick/refactor config #44

Closed patrick-fs closed 5 years ago

patrick-fs commented 5 years ago

Hello and happy almost New Year. I've refactored the ValidateDatabaseSchema() function from my latest merged PR (https://github.com/fullstorydev/hauser/pull/43) so that its invocation in func (rs *Redshift) MakeRedshiftConnection() can be tested.

I've also implemented a pattern using embedded types and interfaces in the config package that binds configuration sections with validator functions (Redshift for now, but could be applied to S3, GCS, root, etc. in the future).

patrick-fs commented 5 years ago

Met with Jess. We're going to target a larger refactor in the future. Closing this PR in light of that.