search

fullstorydev / hauser

Service for moving your Fullstory export files to a data warehouse
MIT License
49 stars 23 forks source link

Reconcile and then update github.com/nishanths/hauser #49

Closed butanian closed 5 years ago

butanian commented 5 years ago

This PR undoes some of the changes that were manually added to nishanths/fullstory in the Hauser project, and updates to the latest version of that package. All the changes have been added to the library here.

In addition, a PR to make it possible to specify a custom user agent has been merged in.

The end goal is to be able to specify a custom user agent so we can gauge how many of our clients rely on Hauser to access their export data.

butanian commented 5 years ago

I will sync up with jh tomorrow to understand his PR where we made Hauser compliant with modules! https://github.com/fullstorydev/hauser/commit/e8f85d157f550ac28674efa3afc0ee95183a89a7

Will ping after it is resolved!

butanian commented 5 years ago

@jameremo resolved the build! PTAL

butanian commented 5 years ago

including @jhump in case I'm missing something. Followed the approach you shared, and it builds correctly now. To verify, I did make test with GOCACHE and GO111MODULE both on and both off.

Manual edits to go.mod -> remove self reference undo module name change