search

fullstorydev / hauser

Service for moving your Fullstory export files to a data warehouse
MIT License
49 stars 23 forks source link

goreleaser config #53

Closed butanian closed 5 years ago

butanian commented 5 years ago

Followed the docs, and tweaked it a little based on jh's grpcui example, and some docs online. As part of the goreleaser build a dist folder is added with all the executables for different platforms.

@sam-fs Depending on how we decide to release these binaries, will have to tweak the config some. Most of the options were from jh's config he created for grpcui. The others were the defaults, and I had to preserve the CGO_ENABLED environment variable in order to build the binary for darwin_amd64

jameremo commented 5 years ago

I have to admit I don't really know what I'm looking at here, and it's going to be a couple days before I have time to dig into the goreleaser docs. Maybe @jhump could take a look if he has some time today?

sam-fs commented 5 years ago

Ditto, but I want to learn more about this. I'll look for open time on Aneesh's calendar next week to get a walk-thru and talk about what may need to change in the config.

--Sam

On Fri, Apr 26, 2019 at 9:05 AM Jessica Greenfield notifications@github.com wrote:

I have to admit I don't really know what I'm looking at here, and it's going to be a couple days before I have time to dig into the goreleaser docs. Maybe @jhump https://github.com/jhump could take a look if he has some time today?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/fullstorydev/hauser/pull/53#issuecomment-487049459, or mute the thread https://github.com/notifications/unsubscribe-auth/AK67X4CHVBWLUA3MYFNLWRDPSL4YTANCNFSM4HIOXETA .

-- Thanks, Sam

jhump commented 5 years ago

I think there are some things missing. For example, you surely want a .gitignore file in here, to ignore the generated dist folder.

Also, you don't need to explicitly set CGO_ENABLED=0 -- CGO is automatically disabled when cross-compiling.

Finally, if you are issuing official releases, you also need to think about version numbers. For that, you'll want to update the Makefile to build the releases for you, and have it do everything necessary to embed the version number in the binary (so you can add a -version flag to it).

I think you basically want to just copy, nearly verbatim, this change from grpcurl: https://github.com/fullstorydev/grpcurl/commit/79a550b8589f3c3e323fc86112397a60714039aa

butanian commented 5 years ago

closing this PR. Will upload a new one after the discussion with @sam-fs today, and include all the changes recommended by @jhump.